Skip to content

Conversation

@ttypic
Copy link
Contributor

@ttypic ttypic commented Mar 17, 2025

Release v1.2.51

Summary by CodeRabbit

  • New Features

    • Request APIs now URL-encode query parameters by default.
    • Enhancements to protocol compliance per updated specifications.
  • Documentation

    • Updated release notes and dependency references to reflect the new version.
  • Chores

    • Incremented version numbers across configurations and updated tests accordingly.

@ttypic ttypic requested a review from sacOO7 March 17, 2025 22:58
@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2025

Walkthrough

This pull request bumps the project version from 1.2.50 to 1.2.51 across various documentation and configuration files. It adds a new changelog entry detailing two enhancements—URL-encoded query parameters by default and the implementation of the RTN11d specification. Additionally, dependency references and version values in CONTRIBUTING.md, README.md, gradle.properties, and a test file are updated accordingly.

Changes

File(s) Change Summary
CHANGELOG.md Added new version entry [1.2.51] with link to the full changelog and two enhancement entries: URL-encoded query parameters by default and implementation of the RTN11d spec point.
CONTRIBUTING.md, README.md Updated dependency versions from 1.2.50 to 1.2.51 for Ably libraries and the network client.
gradle.properties Updated the VERSION_NAME property from 1.2.50 to 1.2.51.
lib/src/test/java/io/ably/lib/test/realtime/RealtimeHttpHeaderTest.java Modified the expected library version in the test assertion from "ably-java/1.2.50" to "ably-java/1.2.51".

Possibly related PRs

  • Release/1.2.47 #1053: Involves version number and changelog updates similar to those in this PR.
  • Release/1.2.42 #1030: Updates the expected library version in test files, aligning with the changes made to RealtimeHttpHeaderTest.java.
  • Release/1.2.50 #1070: Focuses on versioning and changelog documentation updates, sharing a direct connection with this PR’s modifications.

Suggested reviewers

  • sacOO7

Poem

I’m a hopping rabbit in the code meadow,
Leaping through versions with a cheerful glow.
Version 1.2.51 hops in with a brand new beat,
URL-encoded queries, and specs so neat.
My whiskers twitch as tests pass on cue,
Celebrating changes with a joyful “woo-hoo!”
🐰🌟 Happy coding, from me to you!

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 32fb803 and a731679.

📒 Files selected for processing (5)
  • CHANGELOG.md (1 hunks)
  • CONTRIBUTING.md (1 hunks)
  • README.md (2 hunks)
  • gradle.properties (1 hunks)
  • lib/src/test/java/io/ably/lib/test/realtime/RealtimeHttpHeaderTest.java (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: check-rest-okhttp
  • GitHub Check: check-rest
  • GitHub Check: check-realtime-okhttp
  • GitHub Check: check-realtime
🔇 Additional comments (7)
CONTRIBUTING.md (1)

218-218: Version updated correctly to 1.2.51.

The Ably Android library dependency version has been updated to match the new release version.

README.md (3)

23-23: Version updated correctly to 1.2.51.

The Ably Java dependency version has been updated to match the new release version.


29-29: Version updated correctly to 1.2.51.

The Ably Android dependency version has been updated to match the new release version.


515-515: Version updated correctly to 1.2.51.

The network-client-okhttp dependency version has been updated to match the new release version.

CHANGELOG.md (1)

3-10: Added well-structured changelog entry for version 1.2.51.

The changelog entry correctly documents the implemented enhancements in this release:

  1. URL-encoded query parameters by default
  2. Implementation of RTN11d spec point

The entry follows the established format and includes proper links to the related issues.

gradle.properties (1)

2-2: Updated VERSION_NAME to 1.2.51.

The version has been correctly updated in the Gradle properties file, which is essential for the build process to use the new version.

lib/src/test/java/io/ably/lib/test/realtime/RealtimeHttpHeaderTest.java (1)

91-91: Updated version in test assertion to 1.2.51.

The test assertion has been correctly updated to expect the new library version in the agent header, ensuring the test will pass with the updated version.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Collaborator

@sacOO7 sacOO7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ttypic ttypic merged commit 64575b8 into main Mar 18, 2025
12 checks passed
@ttypic ttypic deleted the release/1.2.51 branch March 18, 2025 11:08
@coderabbitai coderabbitai bot mentioned this pull request Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants