Skip to content

Fixed BuildConfig problems#227

Merged
paddybyers merged 1 commit intomasterfrom
buildconfig
Nov 14, 2016
Merged

Fixed BuildConfig problems#227
paddybyers merged 1 commit intomasterfrom
buildconfig

Conversation

@psolstice
Copy link
Copy Markdown
Contributor

No description provided.

@mattheworiordan
Copy link
Copy Markdown
Member

Thanks @psolstice, not clear on what problem specifically this was aiming to solve though?

@paddybyers
Copy link
Copy Markdown
Member

not clear on what problem specifically this was aiming to solve though?

We had a class name conflict with BuildConfig being included twice, once by us and once by the android build framework.

@psolstice
Copy link
Copy Markdown
Contributor Author

psolstice commented Nov 14, 2016

We had a class name conflict with BuildConfig being included twice, once by us and once by the android build framework.

Not quite like that, we had two modules: java and lib each producing their own copy of BuildConfig, I removed BuildConfig from java module. Then I renamed it to AblyBuildConfig to prevent potential conflict with BuildConfig from Android framework. Just in case.

@paddybyers
Copy link
Copy Markdown
Member

LGTM

@paddybyers paddybyers merged commit 9853fb2 into master Nov 14, 2016
@paddybyers paddybyers deleted the buildconfig branch November 14, 2016 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants