#514 AblyRealtime implements Autocloseable#515
Merged
paddybyers merged 1 commit intoably:developfrom Nov 11, 2019
Merged
Conversation
Member
|
LGTM. Should we update tests to reduce noise then where we close explicitly? |
Member
I'm not sure we should embark on a wholesale update of existing tests but, as with other style changes, we should use this for new tests, and take the opportunity to update existing code when we're making other changes. |
Contributor
Author
|
@paddybyers can you merge this? :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #514
AblyRealtime now implements Autocloseable and can be used in
try-with-resources.