ConnectionManager: use HTTPS for the internet-up check#542
Merged
QuintinWillison merged 2 commits intomasterfrom Feb 28, 2020
Merged
ConnectionManager: use HTTPS for the internet-up check#542QuintinWillison merged 2 commits intomasterfrom
QuintinWillison merged 2 commits intomasterfrom
Conversation
paddybyers
added
the
bug
QuintinWillison
previously approved these changes
Dec 18, 2019
This change introduces an event queue for serialisation of all CM-related event handling. In general, state changes, associated notifications, and other event processing, are performed without the CM locked, to avoid the deadlocks that have been prevalent in earlier releases. However, transport state changes that require a synchronous change in CM behaviour - that is, transport disconnections - are handled synchronously so that the transport is not used when it is no longer viable.
QuintinWillison
force-pushed
the
feature/check-connectivity-https
branch
from
3c51d4e to
844b44e
Compare
QuintinWillison
approved these changes
Feb 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #541