Channels visibility improvements#558
Merged
QuintinWillison merged 4 commits intomasterfrom Feb 14, 2020
Merged
Conversation
…ime and REST. Doing as much as I can without this being a breaking change. As far as we are aware, this is only likely to be a breaking change for those mocking AblyRealtime.channels for testing purposes.
Contributor
Author
|
Yes, kids, it's real. Always, always, always run tests before you push! |
Contributor
Author
|
Sorry, @paddybyers, I've broken all kinds of tests. Shall fix those and then re-add my request for review once done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The quick win was making the
channelsfield on realtime instancesfinal- preventing that reference from being trampled.The larger change was a bit more complex, involving (both) the
Channelsinterfaces we have. They were classes but are now interfaces with private implementations, solving the following accessibility issues:newkeyword makes it less obvious that you're creating an instance of an inner class.Aside
I wanted to push further and deprecate the
channelsfields on bothAblyRealtimeandAblyBase, however becauseAblyRealtimeis a subclass ofAblyBaseit was not as easy as just creating agetChannels()method. The problem is that fields can shadow superclass fields and change their type at the same time, even to an incompatible type, but methods can't. And theChannelsreturned by base are of a completely different class to theChannelsreturned by realtime (due to the fact that we also have two forks ofChannelBaseupon which each is ultimately reliant!).