Remove redundant public keywords in the interfaces' definitions#608
Merged
QuintinWillison merged 1 commit intoably:mainfrom Oct 1, 2020
Merged
Conversation
Contributor
|
Hello @vzhikserg ... Nice spot. Thanks for the contribution. I'll get this merged and shall also raise another PR myself to fix some other locations where we have redundant modifiers. 😁 We plan to put checkstyle or similar tooling in place soon in this codebase (#537) which will pick up such transgressions thereon. |
QuintinWillison
approved these changes
Oct 1, 2020
Merged
vzhikserg
added
code-quality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public keyword is not needed for methods of interfaces. They are public by default