Checking if error code is 403 and failing connection#672
Checking if error code is 403 and failing connection#672QuintinWillison merged 6 commits intomainfrom
Conversation
|
Also, I strongly feel, we need to add couple of tests for the change made |
I definitely agree on this, however could you please point me what's the correct place to put them? I've seen there are already test classes but I cannot figurate out how to fail auth to get the correct error code. |
… state transitions to failed state
paddybyers
left a comment
paddybyers
left a comment
There was a problem hiding this comment.
It looks like the requirement isn't implemented - it states that the returned error needs to be wrapped in a new error whose statusCode is 403 and code is 80019.
|
Also, add some details to the active PR, as in which issues it's fixing. |
| @Override | ||
| public void onConnectionStateChanged(ConnectionStateChange stateChange) { | ||
| assertEquals(stateChange.previous, ConnectionState.connected); | ||
| assertEquals(stateChange.reason.code, 80019); |
There was a problem hiding this comment.
This should follow the right format, expected and actual values should be at the right places
|
@QuintinWillison both @KacperKluka and @sacOO7 have approved this btw. But adding you if you wanted to check also Edit - just seen Paddy's comment |
6 participants
Uh oh!
There was an error while loading. Please reload this page.