Skip to content

Using a clientId should no longer be forcing token auth#675

Merged
QuintinWillison merged 1 commit intomainfrom
fix/473-clientId-no-longer-forces-token-auth
Jun 16, 2021
Merged

Using a clientId should no longer be forcing token auth#675
QuintinWillison merged 1 commit intomainfrom
fix/473-clientId-no-longer-forces-token-auth

Conversation

@martin-morek
Copy link
Copy Markdown
Contributor

@martin-morek martin-morek commented May 28, 2021

  • Fixes #345
  • Basic authentication can be used with specified clientId

@sacOO7
Copy link
Copy Markdown
Collaborator

sacOO7 commented Jun 9, 2021

As a part of original issue, it seems there were lot of changes to the spec. I can see RSA4 being removed, but spec still exists for the same. @martin-morek can you double check if all spec changes are being addressed as a part of change? Because I strongly feel we might be missing out on changed spec items, maybe missing tests. Also, spec change looks too long, so I did't get time to go through each spec item. But double checking and making sure, every spec item implementation/ with tests is present will be super helpful

@QuintinWillison
Copy link
Copy Markdown
Contributor

@martin-morek, it sounds like it's worth double checking. Thanks for your input, @sacOO7.

@martin-morek
Copy link
Copy Markdown
Contributor Author

@sacOO7 @QuintinWillison Sorry, but I'm missing out the context a bit. About what spec changes are we talking about? Could you please point me where can I find them to verify?

@sacOO7
Copy link
Copy Markdown
Collaborator

sacOO7 commented Jun 15, 2021

As per original issues, you can see spec changes that happened as a part of PR to the DOC

@martin-morek
Copy link
Copy Markdown
Contributor Author

I've tried to verify it, RSA4 spec should be okey, there are tests for each scenario.

@QuintinWillison QuintinWillison merged commit 27d5801 into main Jun 16, 2021
@QuintinWillison QuintinWillison deleted the fix/473-clientId-no-longer-forces-token-auth branch June 16, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Using a clientId should no longer be forcing token auth in the 1.1 spec

3 participants