Add request_id query param if addRequestIds is enabled#678
Merged
QuintinWillison merged 7 commits intomainfrom Jul 28, 2021
Merged
Add request_id query param if addRequestIds is enabled#678QuintinWillison merged 7 commits intomainfrom
QuintinWillison merged 7 commits intomainfrom
Conversation
QuintinWillison
changed the title
QuintinWillison
requested review from
QuintinWillison
and removed request for
paddybyers
QuintinWillison
suggested changes
Jun 30, 2021
Contributor
QuintinWillison
left a comment
QuintinWillison
left a comment
There was a problem hiding this comment.
Looks good, thanks. Just a bit of refactoring please.
QuintinWillison
approved these changes
Jul 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RSC7c. AddsaddRequestIdsparameter to client options. If this option is enabled every REST request to Ably should include in a request_id query string parameter a random string obtained by url-safe base64-encoding a sequence of at least 9 bytes obtained from a source of randomness. This request ID must remain the same if a request is retried to a fallback host per RSC15. Any log messages associated with the request should include the request ID. If the request fails, the request ID must be included in the ErrorInfo returned to the user.