Skip to content

Separate handling WebsocketNotConnectedException #701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuintinWillison merged 3 commits into from
Aug 27, 2021
Merged

Separate handling WebsocketNotConnectedException #701

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83807e7
Separate handling WebsocketNotConnectedException
martin-morek Aug 13, 2021
6c20c69
Merge branch 'main' into 430-WebSocketNotConnectedException-on-send
martin-morek Aug 26, 2021
39d49ea
Improved exception handling
martin-morek Aug 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/src/main/java/io/ably/lib/transport/WebSocketTransport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import javax.net.ssl.SSLSocketFactory;

import org.java_websocket.client.WebSocketClient;
import org.java_websocket.exceptions.WebsocketNotConnectedException;
import org.java_websocket.framing.CloseFrame;
import org.java_websocket.framing.Framedata;
import org.java_websocket.handshake.ServerHandshake;
Expand Down Expand Up @@ -112,7 +113,14 @@ public void send(ProtocolMessage msg) throws AblyException {
Log.v(TAG, "send(): " + new String(ProtocolSerializer.writeJSON(msg)));
wsConnection.send(ProtocolSerializer.writeJSON(msg));
}
} catch (Exception e) {
}
catch (WebsocketNotConnectedException e){
if(connectListener != null) {
connectListener.onTransportUnavailable(this, AblyException.fromThrowable(e).errorInfo);
} else
throw AblyException.fromThrowable(e);
}
catch (Exception e) {
throw AblyException.fromThrowable(e);
}
}
Expand Down