Removed params overwrite

[martin-morek]

• fixes #705
• listSubscriptionsImpl() input parameters are not overwritten anymore

[QuintinWillison]

Given @paddybyers originally worked on this code then I think it would be good to get his opinion on this change. There may be something we're missing.

[martin-morek]

Test is failing. I'm trying to find out the expected behaviour in the issue ticket.

[uxduck]

I mentioned this in a stand up with Paddy a few weeks ago and he confirmed this is not expected behaviour. The method is completely overwriting the params that a user sets, rendering the arguments a user selects completely useless. Please see #705 for more information.

[uxduck]

I'd like to remove my approval for the time being, since I am not sure what's going here: it's now a draft PR and there has been some code changes.

[martin-morek]

@ben-xd the status has been changed to draft since one test is always failing and it has to be investigated further. I reverted my code changes just to figurate out if those changes caused test failure (which seems not to be the case). Anyway I will change PR status to "Ready" as soon as test will pass.

[QuintinWillison]

There is a lot of information in the linked issue which I was mostly able to follow when I read through it just now, but I'll admit it was a little overwhelming. It sounds like we're removing over-zealous behaviour from this SDK, matching more closely the implementation in the Cocoa SDK. That makes sense - and I'm always a fan of removing code. 😄

Thanks to @ikbalkaya for working on sorting out the emulator runtime issues. I do think there could still be an opportunity to document that better but let's work on that under another pull request.