Skip to content

Fix: Use FirebaseMessaging#getToken() to get registration token#717

Merged
uxduck merged 4 commits intomainfrom
bug/use-registration-token
Sep 28, 2021
Merged

Fix: Use FirebaseMessaging#getToken() to get registration token#717
uxduck merged 4 commits intomainfrom
bug/use-registration-token

Conversation

@uxduck
Copy link
Copy Markdown
Contributor

@uxduck uxduck commented Sep 24, 2021

Use FirebaseMessaging#getToken() to get registration token, instead of FirebaseInstallations#getToken, which returns InstallationTokenResult, which is a:

A new FIS Auth-Token, created for this Firebase Installation

Closes #715

Comment thread README.md Outdated
Comment thread android/src/main/java/io/ably/lib/push/ActivationContext.java
Copy link
Copy Markdown
Contributor

@QuintinWillison QuintinWillison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also seek approval from either @martin-morek or @paddybyers before landing this one.

Copy link
Copy Markdown
Contributor

@martin-morek martin-morek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uxduck uxduck merged commit 9d7d999 into main Sep 28, 2021
@uxduck uxduck deleted the bug/use-registration-token branch September 28, 2021 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Using Firebase installation ID as registration token: Users cannot reactivate the device after deactivating

3 participants