Fix attach/detach race condition#887
Merged
ikbalkaya merged 10 commits intoimprove-cifrom Jan 11, 2023
Merged
Conversation
… sent before detach response is received
…h operation is called when channel is in detaching state
ikbalkaya
changed the title
ikbalkaya
changed the base branch from
main
to
ignore_renew_auth_callback_test
davyskiba
suggested changes
Jan 11, 2023
davyskiba
approved these changes
Jan 11, 2023
Base automatically changed from
ignore_renew_auth_callback_test
to
improve-ci
January 11, 2023 11:02
QuintinWillison
approved these changes
Jan 11, 2023
Contributor
QuintinWillison
left a comment
QuintinWillison
left a comment
There was a problem hiding this comment.
Minor comments that don't change the execution, but might improve the maintainability.
Co-authored-by: Quintin Willison <q@qwuk.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves spec conformance for RTL4h and RTL5i
However I think the spec might be a bit misleading (Please correct me if I'm wrong)
In RTL4h, it writes
I'm not sure if the attach operation should be done after an attach already happened (no need for adding a pending attach). Currently it just register a completion listener if provided and then returns which I think is the correct behaviour. I changed the behaviour when the channel was in DETACHING state so it wouldn't send an attach right away and add a pending attach request to be sent after completion of detach.
The same applies for RTL5i, but in reverse order
Closes #885