Make EventEmitter.on() documentation reflect implementation#889
Merged
Make EventEmitter.on() documentation reflect implementation#889
Conversation
The implementation of this function is incorrect with regards to the spec (RTE4). This change adds documentation to that effect.
Upon adding a duplicate listener, the previous listener (even if for a different event) will be replaced.
QuintinWillison
approved these changes
Jan 11, 2023
AndyTWF
force-pushed
the
update-event-emitter-on-documentation
branch
from
ec09dcc to
a1e2d7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #888
Updates the documentation for EventEmitter.on(1) to correctly reflect its current implementation.