RSL1m4 If clientId is different, error from server#103
Merged
owenpearson merged 1 commit intomainfrom Apr 6, 2021
Merged
Conversation
owenpearson
approved these changes
Apr 1, 2021
Member
owenpearson
left a comment
owenpearson
left a comment
There was a problem hiding this comment.
All good, but I'll wait for 102 to land before merging.
Member
|
@jdavid looks like the error code will need to be updated here too, do you mind updating it and then I'll merge? |
Contributor
Author
|
@owenpearson Done, rebased over main, there's only 1 commit now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #101
Includes commits from PR #102