Skip to content

Improve PHP 8.2 compatibility and testing#173

Merged
AndyTWF merged 14 commits intomainfrom
php82
Feb 22, 2023
Merged

Improve PHP 8.2 compatibility and testing#173
AndyTWF merged 14 commits intomainfrom
php82

Conversation

@AndyTWF
Copy link
Copy Markdown
Contributor

@AndyTWF AndyTWF commented Feb 16, 2023 •
edited
Loading

  • Adds PHP 8.2 compatibility without platform-reqs concessions
  • Updates a flakey test to allow for differences between CI and Server time
  • Removes use of deprecated PHPUnit method (and introduces a wrapper that we can remove once PHP 7.2 is dropped from CI)

Fixes #164

@sacOO7
Copy link
Copy Markdown
Collaborator

sacOO7 commented Feb 16, 2023

Can you update file name for check.yml to build-test.yml ?

@sacOO7
Copy link
Copy Markdown
Collaborator

sacOO7 commented Feb 16, 2023

Also, check if there is a need to update composer.json.

@AndyTWF
Copy link
Copy Markdown
Contributor Author

AndyTWF commented Feb 16, 2023

I believe that check.yml is consistent with the filename conventions in https://github.com/ably/engineering/blob/main/sdk/github.md#filenames

@AndyTWF
Copy link
Copy Markdown
Contributor Author

AndyTWF commented Feb 16, 2023

composer.json appears to be fine - but will double check

@AndyTWF
Add PSR root for tests
5849e42
@AndyTWF
Add trait to wrap regex assertions
4b97d2f 
We're getting warnings for newer PHP verisons around deprecations and
7.2 compatible PHPUnit doesn't appear to support the new version.

This trait wraps the call to proxy it to the appropriately supported
underlying call.
@AndyTWF
Use self
ced0f82
@AndyTWF AndyTWF marked this pull request as ready for review February 16, 2023 16:25
owenpearson
owenpearson approved these changes Feb 16, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@AndyTWF AndyTWF changed the title Add PHP 8.2 compatibility Improve PHP 8.2 compatibility Feb 22, 2023
@AndyTWF AndyTWF changed the title Improve PHP 8.2 compatibility Improve PHP 8.2 compatibility and testing Feb 22, 2023
@AndyTWF AndyTWF merged commit 0824bb6 into main Feb 22, 2023
@AndyTWF AndyTWF deleted the php82 branch February 22, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@owenpearson owenpearson owenpearson approved these changes

@sacOO7 sacOO7 Awaiting requested review from sacOO7

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PHPUnit warning: assertRegExp is deprecated in favour of assertMatchesRegularExpression

3 participants

@AndyTWF @sacOO7 @owenpearson