Merged
Conversation
Test for wildcard being rejected in ClientOptions Tests for authParams and tokenParams overriding in Auth
Fixed AuthTest suite failing to run
… + test Added test for checking that explicit clientId on both published message and library instance works Minor code clean up
…andling Updated type tests Added test suite for spec Auth/clientId edge cases (RSA8f)
Member
|
Looks good, 👍 |
Added a framework to test the Http class and a new test suite for it
Auth now uses defaultTokenParams Created type test for AuthOptions
Moved all clientId related tests to ClientIdTest test suite
Changed tests in AuthTest to verify requestToken() instead of authorise() Added more tests for createTokenRequest() Cleaned up AuthTest test suite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly changes related to handling clientId and proper parameter overriding when generating tokens, with tests.