Skip to content

Issue #26 - Fix proposal for systemTime scientific notation bug #27

Closed
frankie567 wants to merge 1 commit intoably:masterfrom
frankie567:master
Closed

Issue #26 - Fix proposal for systemTime scientific notation bug #27
frankie567 wants to merge 1 commit intoably:masterfrom
frankie567:master

Conversation

@frankie567
Copy link
Copy Markdown

Hi !

Don't want to mess in your code but, maybe that will help :)

Regards !

@bladeSk
Copy link
Copy Markdown
Contributor

bladeSk commented Feb 17, 2016

Thanks for the fix. While this alleviates the issue, systemTime() should be returning a numeric timestamp, not a string, as we can expect developers to perform numeric calculations on it. I believe the root of the problem lies in converting the (floating point) timestamp to a string, which is not consistent across all PHP installations. See #28

Another solution would be to convert the timestamp to int, but that is guaranteed to fail on 32-bit systems. So, for the sake of compatibility and correctness, I chose my solution.

@frankie567
Copy link
Copy Markdown
Author

Ok, understood ! Thanks for the fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants