Issue #26 - Fix proposal for systemTime scientific notation bug #27
Closed
frankie567 wants to merge 1 commit intoably:masterfrom
Closed
Issue #26 - Fix proposal for systemTime scientific notation bug #27frankie567 wants to merge 1 commit intoably:masterfrom
frankie567 wants to merge 1 commit intoably:masterfrom
Conversation
Contributor
|
Thanks for the fix. While this alleviates the issue, Another solution would be to convert the timestamp to int, but that is guaranteed to fail on 32-bit systems. So, for the sake of compatibility and correctness, I chose my solution. |
Author
|
Ok, understood ! Thanks for the fix :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi !
Don't want to mess in your code but, maybe that will help :)
Regards !