Skip to content

Fixed bug with createTokenRequest not working on some PHP configs #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattheworiordan merged 2 commits into from
Feb 17, 2016
Merged

Fixed bug with createTokenRequest not working on some PHP configs #28

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f5ec80
Fixed MAC generation on some platforms where timestamp could collapse…
bladeSk Feb 17, 2016
19379de
Corrected comment regarding timestamp conversion to string
bladeSk Feb 17, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Auth.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,10 +296,12 @@ public function createTokenRequest( $tokenParams = array(), $authOptions = array
}

if ( $authOptions->queryTime ) {
$tokenRequest->timestamp = $this->ably->time();
$tokenRequest->timestamp = sprintf ( "%.0f", $this->ably->time() );
} else if ( empty( $tokenRequest->timestamp ) ) {
$tokenRequest->timestamp = $this->ably->systemTime();
$tokenRequest->timestamp = sprintf ( "%.0f", $this->ably->systemTime() );
}
// note: sprintf converts floating point numbers to plain integers (without scientific notation)
// regardless of the "precision" php.ini setting

if ( empty( $tokenRequest->clientId ) ) {
$tokenRequest->clientId = $authOptions->clientId;
Expand Down