Updated Crypto and CipherParams#31
Merged
bladeSk merged 3 commits intoably:masterfrom Mar 21, 2016
bladeSk:master
Merged
Conversation
… CipherParams. Added tests for new changes, updated tests using old signature.
src/Channel.php
Outdated
| * @param AblyRest $ably Ably API instance | ||
| * @param string $name Channel's name | ||
| * @param array $options Channel options ['encrypted', 'cipherParams'] | ||
| * @param ChannelOpions|array|null $options Channel options (for encrypted channels) |
Member
There was a problem hiding this comment.
Typo, should be ChannelOptions
Member
|
Few comments but otherwise LGTM |
bladeSk
added a commit
that referenced
this pull request
Mar 21, 2016
Updated Crypto and CipherParams
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the enhancement #29