Conversation
paddybyers
requested changes
Feb 6, 2019
Member
paddybyers
left a comment
paddybyers
left a comment
There was a problem hiding this comment.
Looking good but please see comments.
src/Models/DeviceDetails.php
Outdated
|
|
||
| class DeviceDetails extends BaseOptions { | ||
|
|
||
| const DevicePushTransportType = ['fcm', 'gcm', 'apns', 'web']; |
Member
There was a problem hiding this comment.
We've tended not to include this kind of validation check in the library, because then if we do add support for new types it's not possible to access that functionality without having a new library. I think it's best that the backend performs this validation.
| /** | ||
| * @var string | ||
| */ | ||
| public $metadata; |
Member
There was a problem hiding this comment.
In the IDL this is declared to be of type JsonObject
| /** | ||
| * @var string | ||
| */ | ||
| public $push; |
Member
There was a problem hiding this comment.
In the IDL this is declared to be of type DevicePushDetails
src/Models/DeviceDetails.php
Outdated
|
|
||
| if ($this->platform && ! in_array($this->platform, self::DevicePlatform)) { | ||
| throw new \InvalidArgumentException( | ||
| sprintf('unexpected form factor %s', $this->platform) |
Member
There was a problem hiding this comment.
s/form factor/platform, but I guess this code is being removed anyway
Contributor
Author
There was a problem hiding this comment.
Done, could you check?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RHS1b3 New push.admin.device_registrations.save