Conversation
The dev environments don't work with push.
Contributor
Author
|
The push tests fail with the Then the idempotent tests fail since idempotency is not supported in |
Contributor
Author
|
ping @paddybyers |
mattheworiordan
requested changes
Mar 27, 2019
Member
mattheworiordan
left a comment
mattheworiordan
left a comment
There was a problem hiding this comment.
Looks good, but think this PR still assumes idempotent is not available in sandbox
This reverts commit 6f85b9f.
Contributor
Author
|
Not skipping idempotent tests in sandbox now. Can I merge this? @mattheworiordan @paddybyers |
mattheworiordan
approved these changes
Apr 11, 2019
Member
mattheworiordan
left a comment
mattheworiordan
left a comment
There was a problem hiding this comment.
LGTM. Know why tests are failing though?
Contributor
Author
|
Don't know. This same test was failing around December if I remember correctly, @paddybyers looked at it as well but didn't find why. Then the failure disappeared, and now it's back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.