Conversation
list is a reserved word
Contributor
Author
|
ping |
mattheworiordan
approved these changes
May 31, 2019
Member
mattheworiordan
left a comment
mattheworiordan
left a comment
There was a problem hiding this comment.
LGTM, although if you vary from the spec, and thus violate the docs, you need to make sure the docs repo reflects that change please.
| * | ||
| * @param array $params the parameters used to filter the list | ||
| */ | ||
| public function list_ (array $params = []) { |
Member
There was a problem hiding this comment.
@jdavid if you are using a method that is different to the spec, then you need to update the docs in https://github.com/ably/docs. Can you do a PR for that to update general/push/admin?
@tomczoink see below. Do we need to create an issue for this?
Member
There was a problem hiding this comment.
In fact @tomczoink, the problem is worse. Where has Push gone in the documentation nav?? See below for the docs repo nav.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RSH1c1 New push->admin->channelSubscriptions->list_
list is a reserved word