Skip to content

Fix test case in local environment#95

Merged
owenpearson merged 2 commits intomainfrom
headerscase
Mar 4, 2021
Merged

Fix test case in local environment#95
owenpearson merged 2 commits intomainfrom
headerscase

Conversation

@jdavid
Copy link
Copy Markdown
Contributor

@jdavid jdavid commented Feb 24, 2021

This doesn't show up in CI, but I have this error locally:

1) tests\HttpTest::testRequestBasic
Expected headers to be an array containing key `Content-Type`
Failed asserting that an array has the key 'Content-Type'.

/home/jdavid/sandboxes/Ably/ably-php/tests/HttpTest.php:143

This PR fixes that unit test.

@jdavid
Fix tests locally
b186aad 
For some reason curl returns the keys in response headers as lowercase,
in my local environment. Make them Title-Case.
@jdavid
Style: reduce width of some lines
69b23d3
@owenpearson owenpearson merged commit 8441451 into main Mar 4, 2021
@owenpearson owenpearson deleted the headerscase branch March 4, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@owenpearson owenpearson owenpearson approved these changes

@QuintinWillison QuintinWillison Awaiting requested review from QuintinWillison

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jdavid @owenpearson