-
Notifications
You must be signed in to change notification settings - Fork 27
Release/3.0.0 #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/3.0.0 #666
Conversation
WalkthroughThis PR updates package version to v3.0.0 and documentation: adds a v3.0.0 changelog, expands the UPDATING migration guide with breaking-change details, updates README platform/deprecation notes, and bumps the package metadata version and classifiers. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Realtime_WS as Realtime WebSocket
participant Realtime_Server as Realtime Server
participant Storage as Message Store / Publish Result
Client->>Realtime_WS: open WS connection & send publish
Realtime_WS->>Realtime_Server: forward publish frame
Realtime_Server->>Storage: persist message, assign serial
Storage-->>Realtime_Server: publish result (serials)
Realtime_Server-->>Realtime_WS: ack with publish result
Realtime_WS-->>Client: deliver publish result (serialized)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
🤖 Fix all issues with AI agents
In `@pyproject.toml`:
- Line 25: The pyproject.toml currently lists the classifier "Programming
Language :: Python :: 3.14" but the repo lacks CI coverage for 3.14; either
remove that exact classifier string from pyproject.toml or add Python 3.14 to
your CI test matrix by updating your CI workflow's test job (look for a job
named "test" that uses actions/setup-python) to include "3.14" in the matrix of
python-version values so the declared supported version is actually tested.
In `@README.md`:
- Around line 38-42: The blockquote contains an extra blank line between the two
admonition lines causing markdownlint MD028; remove the empty line so the lines
starting with "[!NOTE]" and "[!IMPORTANT]" are adjacent within the same
blockquote, ensuring there is no blank line inside that blockquote in README.md.
In `@UPDATING.md`:
- Around line 5-11: The unordered bullet list in UPDATING.md is indented and
triggers markdownlint MD007; remove the leading indentation so each
hyphen-started line is flush-left (align the lines starting with "-" for the
four bullets: "Realtime publish now...", "`ably.realtime.realtime_channel`
module...", "ChannelOptions moved...", and "REST publish returns...") ensuring
the list is a top-level list under the paragraph above.
- Added instructions for updating to v3.0.0 in `UPDATING.md` - Detailed breaking changes and enhancements in `CHANGELOG.md`
owenpearson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@CHANGELOG.md`:
- Line 12: Update the wording in the CHANGELOG entry that currently reads
"serial of published messages" to use the plural "serials of published messages"
so it matches the API behavior and the wording used elsewhere (e.g., the
UPDATING.md entry and the similar line later in the changelog); locate the exact
line in CHANGELOG.md and replace the singular "serial" with "serials".
♻️ Duplicate comments (1)
UPDATING.md (1)
7-10: Fix unordered list indentation (MD007).
This duplicates prior feedback; keep the list flush-left.✏️ Proposed fix
- - The realtime channel publish method now uses WebSocket connection instead of REST - - `ably.realtime.realtime_channel` module renamed to `ably.realtime.channel` - - `ChannelOptions` moved to `ably.types.channeloptions` - - REST publish returns publish result with message serials instead of Response object +- The realtime channel publish method now uses WebSocket connection instead of REST +- `ably.realtime.realtime_channel` module renamed to `ably.realtime.channel` +- `ChannelOptions` moved to `ably.types.channeloptions` +- REST publish returns publish result with message serials instead of Response object
What's Changed
Summary by CodeRabbit
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.