Merged
Conversation
Morganamilo
force-pushed
the
idiomaticify2
branch
from
3e50013 to
90703d5
Compare
added 6 commits
June 28, 2022 10:36
This is rather huge and I wish it was split more commits but most of the code didnt compile through this process. This makes AuthParms and AuthOptions direct arguments to the auth functions, doing away with the builder functions. Having a separate builder type for both functions, and each having functions to set all the auth options/parms options seemed quite a bit overkill. Especially as the user may wish to save these structs for reuse. I also found it a bit confusing personally. I've also tweaked what is and isn't an option. This is surely not 100% correct and the spec is not the best at laying this out so I'm sure more work will be needed. This also combines things that can't be set at the same time into enums. For auth at anyway, this still needs to be done for client options.
This makes it impossible to not supply one at compile time and removes an error condition. This also removes some (try)into impls and adds some helper functions.
Saves always duplicating the whole client options.
Makes it clear they are not chain functions.
Morganamilo
force-pushed
the
idiomaticify2
branch
from
3d3e040 to
669a2e2
Compare
lmars
reviewed
Jun 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is rather huge and I wish it was split more commits but most of the
code didnt compile through this process.
This makes AuthParms and AuthOptions direct arguments to the auth
functions, doing away with the builder functions. Having a separate
builder type for both functions, and each having functions to set all
the auth options/parms options seemed quite a bit overkill. Especially
as the user may wish to save these structs for reuse. I also found it
a bit confusing personally.
I've also tweaked what is and isn't an option. This is surely not 100%
correct and the spec is not the best at laying this out so I'm sure more
work will be needed.
This also combines things that can't be set at the same time into enums.
For auth at anyway, this still needs to be done for client options.