-
Notifications
You must be signed in to change notification settings - Fork 45
[WEB-4688] Add UI basis for redesigned footer component #2968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
3a77f8a to
9786a76
Compare
3e6a41d to
724b866
Compare
724b866 to
9ed4d35
Compare
9ed4d35 to
a1540e2
Compare
aralovelace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a1540e2 to
7b1361e
Compare
|
Woops @aralovelace you shouldn't see the feedback unit - it's supposed to be hidden in this PR as the wider purpose of it is still undecided. I toggled it on to take a screenshot and accidentally committed it. Updated that now. As for the "Edit on Github" bit, it's situational, you'll only get it on the (I guess you could call them) standard docs pages like this. You won't get it on the homepage for instance as we don't want to invite people to edit that on Github. There could be a "last updated" field as well, but that data isn't actually available anywhere atm. As for the wideness, it's a good point - this is part of some Jamie W feedback as well and will be addressed once all these base pieces are in place. |
aralovelace
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I dont see it anymore now
and overlooks good

This PR adds the basis for the redesigned footer component that forms part of the wider navigation rewrite. However, due to misalignment, this PR isn't the whole story - we're missing the full feedback-reporting functionality (though the UI for it is here), and the 'last updated' field is driven by frontmatter (currently a new field and therefore unpopulated) instead of an existing data source.
I will return to the feedback functionality once there's further clarity on it, but I may as well push forwards on the UI.
To test, go on the review app and look around, ensuring it works well at different viewports. This is a pretty surface level change so doesn't require deep testing.
For completeness, here's a snap of the feedback form when enabled:
