Skip to content

Conversation

@jamiehenson
Copy link
Member

@jamiehenson jamiehenson commented Nov 18, 2025

This PR adds the basis for the redesigned footer component that forms part of the wider navigation rewrite. However, due to misalignment, this PR isn't the whole story - we're missing the full feedback-reporting functionality (though the UI for it is here), and the 'last updated' field is driven by frontmatter (currently a new field and therefore unpopulated) instead of an existing data source.

I will return to the feedback functionality once there's further clarity on it, but I may as well push forwards on the UI.

Screenshot 2025-11-27 at 14 38 12

To test, go on the review app and look around, ensuring it works well at different viewports. This is a pretty surface level change so doesn't require deep testing.

For completeness, here's a snap of the feedback form when enabled:
Screenshot 2025-11-27 at 14 43 25

@coderabbitai
Copy link

coderabbitai bot commented Nov 18, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch web-4688-footer

Comment @coderabbitai help to get the list of available commands and usage tips.

@jamiehenson jamiehenson force-pushed the web-4684-docs-redesign branch 3 times, most recently from 3a77f8a to 9786a76 Compare November 27, 2025 14:32
@jamiehenson jamiehenson changed the title [WEB-4688] Add PostHog feedback integration to Footer [WEB-4688] Add redesigned footer component Nov 27, 2025
@jamiehenson jamiehenson added the review-app Create a Heroku review app label Nov 27, 2025
@ably-ci ably-ci had a problem deploying to ably-docs-web-4688-foot-yzhcsf November 27, 2025 14:37 Failure
@jamiehenson jamiehenson temporarily deployed to ably-docs-web-4688-foot-yzhcsf November 27, 2025 14:40 Inactive
@jamiehenson jamiehenson marked this pull request as ready for review November 27, 2025 14:44
@jamiehenson jamiehenson changed the title [WEB-4688] Add redesigned footer component [WEB-4688] Add UI basis for redesigned footer component Nov 27, 2025
@ably-ci ably-ci temporarily deployed to ably-docs-web-4688-foot-q8ro4g November 27, 2025 15:05 Inactive
Copy link
Contributor

@aralovelace aralovelace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you enable the Edit on Github? cant seem to see that on my page

Also if the page is too wide is this the expected?

Image

@jamiehenson jamiehenson temporarily deployed to ably-docs-web-4688-foot-q8ro4g November 27, 2025 15:43 Inactive
@jamiehenson
Copy link
Member Author

jamiehenson commented Nov 27, 2025

Woops @aralovelace you shouldn't see the feedback unit - it's supposed to be hidden in this PR as the wider purpose of it is still undecided. I toggled it on to take a screenshot and accidentally committed it. Updated that now.

As for the "Edit on Github" bit, it's situational, you'll only get it on the (I guess you could call them) standard docs pages like this. You won't get it on the homepage for instance as we don't want to invite people to edit that on Github. There could be a "last updated" field as well, but that data isn't actually available anywhere atm.

As for the wideness, it's a good point - this is part of some Jamie W feedback as well and will be addressed once all these base pieces are in place.

Copy link
Contributor

@aralovelace aralovelace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I dont see it anymore now

and overlooks good

@jamiehenson jamiehenson merged commit 6015277 into web-4684-docs-redesign Nov 28, 2025
7 checks passed
@jamiehenson jamiehenson deleted the web-4688-footer branch November 28, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-app Create a Heroku review app

Development

Successfully merging this pull request may close these issues.

4 participants