[WEB-4839] Remove textile support #2992
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
kennethkalmer
force-pushed
the
WEB-4839-remove-textile
branch
from
89f82a9 to
6a47341
Compare
GregHolmes
force-pushed
the
WEB-4839-remove-textile
branch
from
6a47341 to
a7c2441
Compare
kennethkalmer
force-pushed
the
WEB-4839-remove-textile
branch
2 times, most recently
from
4c2c34b to
82d4585
Compare
GregHolmes
force-pushed
the
WEB-4839-remove-textile
branch
from
82d4585 to
e840b48
Compare
GregHolmes
left a comment
GregHolmes
left a comment
There was a problem hiding this comment.
Looks good to me! Can't see any issues.
kennethkalmer
force-pushed
the
WEB-4839-remove-textile
branch
2 times, most recently
from
0c37385 to
07dfd12
Compare
Remove all code that processes textile files and ERB templates from the build pipeline. Textile content files remain in the repository but are no longer parsed or rendered. Changes: - Remove textile-js imports and usage from createPages and onCreateNode - Remove ERB processing from pre-parser pipeline - Remove textile-partials handling from transform utilities - Update parser steps to remove ERB and textile workarounds After this commit, the build generates 241 MDX pages with no textile processing. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Remove all textile and ERB processing infrastructure code now that the build pipeline no longer uses it. This includes workarounds, utilities, and tests that validated textile parsing behavior. Deleted: - textile-js-workarounds directory (28 files) - erbjs directory (ERB processing, 6 files + tests) - Textile utility files and type definitions - Test files dependent on textile/ERB processing The build continues to work with no textile processing infrastructure. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Remove all textile content files from the repository. These files have already been converted to MDX format and are no longer needed. Deleted: - content/partials/ directory (96 textile files) - index.textile The content now exists exclusively in MDX format. Build continues to work with 241 pages generated from MDX sources. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Remove all packages and configuration related to textile processing now that textile support has been completely removed from the codebase. Packages removed: - textile-js: Textile markup language parser - turndown: HTML to Markdown converter (used in textile debugging) - diff: Text diffing library (used in textile debugging) - @types/turndown: TypeScript types for turndown - @types/diff: TypeScript types for diff Configuration removed: - debug:textile script from package.json - textile-partials filesystem plugin from gatsby-config.ts - textile-nanoc-compatible filesystem plugin from gatsby-config.ts The repository no longer has any textile-related dependencies. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Update references in documentation and style guide to remove mentions of textile format now that it is no longer supported. Changes: - Update CONTRIBUTING.md to remove textile references - Fix prettier formatting in src/pages/docs/404.js - Update writing-style-guide.md to remove textile mention 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
jamiehenson
force-pushed
the
WEB-4839-remove-textile
branch
from
34eaaf3 to
ade5995
Compare
jamiehenson
left a comment
jamiehenson
left a comment
There was a problem hiding this comment.
its so beautiful
@kennethkalmer @GregHolmes Looks great, only small comments.
As a followup - whilst structural docs knowledge is still fresh in my head, I've added an additional commit here that cuts much deeper into the fat we can chop in a post-textile world. TLDR, there's a lot, given that our new page composition approach is considerably leaner than the ecosystem of wrappers, components and contexts we had before.
With this commit I've tried to keep things in place (i.e. it's 90% a delete operation versus a refactor). It also sweeps up a couple of the remaining references to Textile in various docs that Claudio missed the first time. Tests pass and builds complete, but given the size of it, let me know if you'd rather me separate this stuff out into a separate PR.
| ### Admonitions | ||
|
|
||
| There are three types of admonition that can be used; `note`, `important` and `further-reading`. Update the value of `data-type` to switch between them. Admonitions are written using the HTML `<aside>` tag. Content must be constructed in HTML, other than links and in-line code styling which accept textile format. | ||
| There are three types of admonition that can be used; `note`, `important` and `further-reading`. Update the value of `data-type` to switch between them. Admonitions are written using the HTML `<aside>` tag with HTML or Markdown content. |
There was a problem hiding this comment.
nit: we can do eight. note, further-reading, important, warning (unused) and neutral (unused) in the new style, new, updated and experimental in the old Aside style.
I'll leave this info in your hands, but it seems like we should only encourage use of the "new style" ones, which means adding neutral and warning to this list.
| gtmContainerId, | ||
| headwayAccountId, | ||
| inkeepChatEnabled, | ||
| inkeepSearchEnabled, |
Description
Now that everything is on MDX we can remove support for textile completely, including the remaining unused Textile files.
Note
This is entirely done by Claudius, with some documentation updates from @GregHolmes. I've pushed Claudius through several rounds to keep cleaning up as much as it can, and I think we've reached a good point.
Checklist