fix: use enums instead of string literals for message actions in java and python#3174
Merged
GregHolmes merged 1 commit intomainfrom Feb 2, 2026
Merged
fix: use enums instead of string literals for message actions in java and python#3174GregHolmes merged 1 commit intomainfrom
GregHolmes merged 1 commit intomainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
GregHolmes
requested changes
Feb 2, 2026
| current = responses.get(message.serial, '') | ||
| responses[message.serial] = current + message.data | ||
| elif action == 'message.update': | ||
| elif action == MessageAction.MESSAGE_UPDATE': |
Contributor
There was a problem hiding this comment.
Suggested change
| elif action == MessageAction.MESSAGE_UPDATE': | |
| elif action == MessageAction.MESSAGE_UPDATE: |
| # New response started | ||
| responses[message.serial] = message.data | ||
| elif action == 'message.append': | ||
| elif action == MessageAction.MESSAGE_APPEND': |
Contributor
There was a problem hiding this comment.
Suggested change
| elif action == MessageAction.MESSAGE_APPEND': | |
| elif action == MessageAction.MESSAGE_APPEND: |
… and python use messages constructor for python publishes
c9d89f8 to
d997f57
Compare
GregHolmes
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist