fix(push): use onNewRegistrationToken instead of activate() on FCM token refresh#3282
Merged
fix(push): use onNewRegistrationToken instead of activate() on FCM token refresh#3282
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
maratal
requested review from
umair-ably
and removed request for
lawrence-forooghian and
sacOO7
umair-ably
approved these changes
Apr 16, 2026
…ken refresh Calling activate() in onNewToken triggers a full device registration flow (CalledActivate state machine event). The correct approach is onNewRegistrationToken, which fires GotPushDeviceDetails — updating the stored token and re-registering with Ably only if the device is already activated. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
maratal
force-pushed
the
dx-973-Push-activate-a-noop
branch
from
1d287b4 to
268a7bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
push.activate()inonNewTokenwithpush.getActivationContext().onNewRegistrationToken(RegistrationToken.Type.FCM, token)activate()triggers a full device registration flow (CalledActivatestate machine event), which is wrong for a token refreshonNewRegistrationTokenfiresGotPushDeviceDetails— updating the stored token and re-registering with Ably only if the device is already activatedimport io.ably.lib.types.RegistrationToken🤖 Generated with Claude Code
https://ably.atlassian.net/browse/DX-973