COL-595: Error on getting channel with 'agent' params if user has already 'got' the channel #155
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
temporarily deployed
to
staging/pull/155/typedoc
github-actions
bot
temporarily deployed
to
staging/pull/155/typedoc
github-actions
bot
temporarily deployed
to
staging/pull/155/typedoc
snikidev
force-pushed
the
col-595-set-options
branch
from
fed52c4 to
581737e
Compare
github-actions
bot
temporarily deployed
to
staging/pull/155/typedoc
src/stream/Stream.ts
Outdated
| this.ablyChannel = this.ably.channels.get(this.options.channelName); | ||
|
|
||
| if (this.ablyChannel.state !== 'attached' && this.ablyChannel.state !== 'attaching') { | ||
| this.ablyChannel.setOptions({ params: { agent: `models/${VERSION}` } }); |
There was a problem hiding this comment.
This returns a promise, we should await here
src/utilities/test/createAblyApp.ts
Outdated
| @@ -0,0 +1,88 @@ | |||
| import ky from 'ky'; | |||
There was a problem hiding this comment.
Any reason not to use fetch? And avoid an additional dependency
There was a problem hiding this comment.
Nope. ky is good for server as well, I just forgot that we only use it in tests 😅
src/stream/Stream.test.ts
Outdated
| hasNext: () => false, | ||
| }), | ||
| ); | ||
| channel.setOptions = vi.fn(); |
There was a problem hiding this comment.
Let's set this by default on the mockChannel set up before the tests run.
mschristensen
left a comment
mschristensen
left a comment
There was a problem hiding this comment.
I think some not-needed things in the test setup, but otherwise good and happy to merge once fixed
| const name = 'test'; | ||
| const data = await createAblyApp({ | ||
| keys: [{}], | ||
| namespaces: [{ id: name, persisted: true }], |
There was a problem hiding this comment.
It doesn't look like we need a namespace for this test?
| channels: [ | ||
| { | ||
| name, | ||
| presence: [ |
There was a problem hiding this comment.
It doesn't look like we need a presence set for this test?
snikidev
force-pushed
the
col-595-set-options
branch
from
560d766 to
494268a
Compare
No description provided.