Merged
Conversation
SimonWoolf
approved these changes
Apr 25, 2025
Member
SimonWoolf
left a comment
SimonWoolf
left a comment
There was a problem hiding this comment.
lgtm.
(I don't think we need to include "It was valid up to and including specification version..." language for changes which are just improving clarity, not actually changing the expected behaviour)
It's unclear (how should the SDK determine if this has occurred?) and seems redundant.
lawrence-forooghian
force-pushed
the
remove-RTL4e
branch
from
5d59ba4 to
81c89f4
Compare
Collaborator
Author
Sure, have removed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's unclear (how should the SDK determine if this has occurred?) and seems redundant.