Skip to content

Add output data format version to header #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2021
Merged

Add output data format version to header #28

merged 1 commit into from
Aug 30, 2021

Conversation

@AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Aug 30, 2021

Adds a new attribute output_format_version to the scancode header
to support output data format versioning.
See aboutcode-org/scancode-toolkit#2653 for more details.

Signed-off-by: Ayan Sinha Mahapatra ayansmahapatra@gmail.com

@AyanSinhaMahapatra
Add output data format version to header
1b79e15 
Adds a new attribute `output_format_version` to the scancode header
to support output data format versioning.
See aboutcode-org/scancode-toolkit#2653 for more details.

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra AyanSinhaMahapatra force-pushed the 2653-add-output-format-version-to-header branch from 036061f to 1b79e15 Compare August 30, 2021 15:40
pombredanne
pombredanne previously approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pombredanne
Copy link
Member

pombredanne commented Aug 30, 2021

but in hindsight, is output_data_format the best name for this? Output is about a process...
What about data_format_version instead?

@pombredanne pombredanne dismissed their stale review August 30, 2021 16:19

is output_data_format the best name for this? Output is about a process... What about data_format_version instead?

pombredanne
pombredanne requested changes Aug 30, 2021
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO data_format_version or format_version may be better names

@pombredanne
Copy link
Member

pombredanne commented Aug 30, 2021

IMHO data_format_version or format_version may be better names

Actually your name is better. Let's keep this!

@pombredanne pombredanne merged commit cdbf041 into aboutcode-org:main Aug 30, 2021
@AyanSinhaMahapatra
Copy link
Member Author

AyanSinhaMahapatra commented Aug 30, 2021

Btw, just for info, this was renamed from data_format_version (as discussed here) to output_format_version as IMHO data in scancode usually refers to the licenses/rules data, and so this could create confusion as this is more format versioning of the output, rahter than the data. Hence the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pombredanne pombredanne pombredanne requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AyanSinhaMahapatra @pombredanne