Skip to content

Conversation

@35C4n0r
Copy link
Contributor

@35C4n0r 35C4n0r commented Jan 11, 2023

Some minor fixes in:

  1. debutils.py: Now email can be correctly extracted.
  2. mappers/debian.py: Now we can correctly seperate dependacy name and constraint versions.

Signed-off-by: Jay jaykumar20march@gmail.com

Signed-off-by: Jay <jaykumar20march@gmail.com>
@JonoYang
Copy link
Member

JonoYang commented Feb 9, 2023

@35C4n0r Sorry for the late response. Can you add a new test to https://github.com/nexB/purldb/blob/main/minecode/tests/test_debian.py, so that we can make sure that emails are extracted properly?

Added New tests for Parse Email, Rollbacked changes for get_dependancies() for now.
Signed-off-by: Jay <jaykumar20march@gmail.com>
Added New tests for Parse Email, Rollbacked changes for get_dependancies() for now.
Signed-off-by: Jay <jaykumar20march@gmail.com>
Signed-off-by: Jay <jaykumar20march@gmail.com>
@35C4n0r
Copy link
Contributor Author

35C4n0r commented Feb 11, 2023

@JonoYang I've updated and addee few new tests for checking email.
Also the changes for get_dependencies have been rollbacked for now.

@JonoYang
Copy link
Member

@35C4n0r Thanks! I left a small comment.

Added .env in .gitignore
Signed-off-by: Jay <jaykumar20march@gmail.com>
@35C4n0r
Copy link
Contributor Author

35C4n0r commented Feb 14, 2023

@35C4n0r Thanks! I left a small comment.

@JonoYang Done!!! please review again, also i've added .env in the .gitignore file.

@JonoYang JonoYang merged commit 69d8556 into aboutcode-org:main Feb 15, 2023
@JonoYang
Copy link
Member

@35C4n0r Looks good, I'm merging this. Thanks you!

@35C4n0r 35C4n0r mentioned this pull request Feb 16, 2023
JonoYang added a commit that referenced this pull request Apr 14, 2025
Some minor fixes in minecode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants