Skip to content

Clean cli output #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 29, 2022
Merged

Clean cli output #43

merged 2 commits into from
Jul 29, 2022

Conversation

@TG1999
Copy link
Contributor

@TG1999 TG1999 commented Jul 22, 2022 •
edited
Loading

closes #40

@TG1999 TG1999 force-pushed the clean_cli_output branch 3 times, most recently from 91a9d22 to f97a90b Compare July 22, 2022 11:19
@TG1999 TG1999 requested a review from pombredanne July 22, 2022 11:23
pombredanne
pombredanne approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor nit... but there seems to be changes already covered in #42 ? Are these the same?

@pombredanne pombredanne mentioned this pull request Jul 27, 2022
Merged
@TG1999
Copy link
Contributor Author

TG1999 commented Jul 27, 2022

I have cut a branch from #42 here, will rebase once #42 gets merged

@TG1999
Do not log anything by default
1f243cb 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 TG1999 force-pushed the clean_cli_output branch from f97a90b to f05ad97 Compare July 29, 2022 12:42
@TG1999
Address review comments
be60160 
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 TG1999 force-pushed the clean_cli_output branch from f05ad97 to be60160 Compare July 29, 2022 12:46
@TG1999
Copy link
Contributor Author

TG1999 commented Jul 29, 2022

Thanks! merging

@TG1999 TG1999 merged commit 93df5a6 into main Jul 29, 2022
@pombredanne pombredanne deleted the clean_cli_output branch July 29, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Do not log anything by default

3 participants

@TG1999 @pombredanne