Skip to content

Handle string is private #4635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AyanSinhaMahapatra merged 2 commits into from
Dec 11, 2025
Merged

Handle string is private #4635

AyanSinhaMahapatra merged 2 commits into from
Dec 11, 2025

Conversation

@AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Dec 11, 2025

Fixes #4631

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

@AyanSinhaMahapatra
Add test with string is_private package.json
7ca178b 
Signed-off-by: Ayan Sinha Mahapatra <asmahapatra@aboutcode.org>
@AyanSinhaMahapatra
Handle string is_private in npm package.json
e5866d3 
Reference: #4631
Signed-off-by: Ayan Sinha Mahapatra <asmahapatra@aboutcode.org>
@AyanSinhaMahapatra AyanSinhaMahapatra mentioned this pull request Dec 11, 2025
Closed
@tdruez
Copy link
Contributor

tdruez commented Dec 11, 2025

@AyanSinhaMahapatra LGTM!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit c05a13d into develop Dec 11, 2025
38 of 41 checks passed
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the handle-string-is-private branch December 11, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdruez tdruez Awaiting requested review from tdruez

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

is_private returned as str in place of boolean

2 participants

@AyanSinhaMahapatra @tdruez