Fix handling of git-authenticated npm dependencies being misdetected as aliases #4754
Open
dikshaa2909 wants to merge 1 commit intoaboutcode-org:developfrom
Open
Fix handling of git-authenticated npm dependencies being misdetected as aliases #4754dikshaa2909 wants to merge 1 commit intoaboutcode-org:developfrom
dikshaa2909 wants to merge 1 commit intoaboutcode-org:developfrom
Conversation
…-org#4753) Signed-off-by: dikshaa2909 <dikshadeware@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4753
Summary
Fix incorrect alias detection for git-authenticated npm dependencies.
Dependencies like:
"private-lib": "git+ssh://git@github.com:org/repo.git#v1.0.0"
were incorrectly treated as alias dependencies because the logic only checked for ":" and "@" in the requirement string.
This change excludes git-based URLs (git+, git:, git@, ssh://, http://, https://) from alias detection.
Changes
Tasks