Redesigning welcome page#477
Conversation
Vishal-raj-1
force-pushed
the
welcome-page
branch
from
6bc3fe5 to
a8c00a9
Compare
Vishal-raj-1
force-pushed
the
welcome-page
branch
from
6753454 to
b3440ec
Compare
Preview
@MaJuRG Now I have update . Sir, You can check the preview. |
steven-esser
left a comment
steven-esser
left a comment
There was a problem hiding this comment.
This is slightly better, but the buttons are not centered like the large icons above.
|
@MaJuRG is this look good ? |
steven-esser
left a comment
steven-esser
left a comment
There was a problem hiding this comment.
@Vishal-raj-1 This looks great now, thanks!
Two things left before I can merge:
- Please squash your commits on this PR to single one.
- Please address the lint errors found here:
1) ESLint
validates /home/travis/build/nexB/scancode-workbench/assets/app/js/controllers/conclusionDialog.js:
AssertionError: 210:23 Strings must use singlequote - quotes
232:23 Strings must use singlequote - quotes
253:23 Strings must use singlequote - quotes
275:23 Strings must use singlequote - quotes
309:23 Strings must use singlequote - quotes
334:23 Strings must use singlequote - quotes
361:23 Strings must use singlequote - quotes
382:23 Strings must use singlequote - quotes
at Context.it (test/eslint.test.js:41:14)
You can verify linting prior to pushing via running npm test
Vishal-raj-1
force-pushed
the
welcome-page
branch
from
ac9155f to
d1b6b58
Compare
Signed-off-by: Vishal-raj-1 <rajputvishal33786@gmail.com>
Vishal-raj-1
force-pushed
the
welcome-page
branch
from
d1b6b58 to
cc49b53
Compare
|
@MaJuRG Sir I have resolved the Lint error. Please review it !! |
|
Thanks for merging @MaJuRG sir !! |
|
This looks awesome, sorry I was not active due to some personal reasons. Shall I send the icons that I've used in the design? |
Yes sir !! I will replace this with your icons. Which looks cools to me !! |
3 participants
Description
I have redesign the welcome page. It will fixes #447 .
Preview
@MaJuRG Please review it !!