Add ability to register pipelines through a SCANCODEIO_PIPELINES_DIRS… #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… setting #237 Signed-off-by: Thomas Druez <tdruez@nexb.com>
|
@pombredanne could you have a look at the changes before the merge? |
pombredanne
reviewed
Jul 19, 2021
scanpipe/apps.py
Outdated
| pipeline_classes = inspect.getmembers(module, is_pipeline) | ||
|
|
||
| if len(pipeline_classes) > 1: | ||
| raise ImproperlyConfigured("Only 1 Pipeline class allowed per file.") |
There was a problem hiding this comment.
Suggested change
| raise ImproperlyConfigured("Only 1 Pipeline class allowed per file.") | |
| raise ImproperlyConfigured(f"Only one Pipeline class allowed per pipeline file: {path}.") |
|
|
||
| elif pipeline_classes: | ||
| pipeline_class = pipeline_classes[0][1] | ||
| self.register_pipeline(name=module_name, cls=pipeline_class) |
There was a problem hiding this comment.
Are we checking that the name is new and unique and does not mask the existing pipelines?
There was a problem hiding this comment.
Co-authored-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Thomas Druez <tdruez@nexb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… setting #237
Signed-off-by: Thomas Druez tdruez@nexb.com