-
-
Notifications
You must be signed in to change notification settings - Fork 247
Add Alpine Linux APKBUILD importer (#509) #2026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Alpine Linux APKBUILD importer (#509) #2026
Conversation
8593c96 to
2792a13
Compare
Signed-off-by: karthiknew07 <karthik2005207@gmail.com>
2792a13 to
797a42a
Compare
|
Hey @karthiknew07 thanks for the contribution, https://github.com/aboutcode-org/vulnerablecode/tree/main/vulnerabilities/pipelines/v2_importers We are using these type of importer pipelines now. Can you adjust/migrate your code accordingly. Also see: If you need any help, let us know. Thanks! |
|
Thank you for the feedback and guidance! I appreciate you pointing me to the v2 pipeline format and issue #1944. I'm currently working on migrating the Alpine importer to the new pipeline structure. I'll be:
I'll have an updated PR ready shortly. If I run into any issues during the migration, I'll reach out. Thanks again for your guidance! |
|
✅ Migration to v2 pipeline complete! The importer has been successfully migrated to the new pipeline format: Changes:
Verification:
Ready for review! @TG1999 |
Signed-off-by: karthiknew07 <karthik2005207@gmail.com>
8d603c0 to
ec0ba42
Compare
| self.log("Fetching Alpine Linux APKBUILD files") | ||
|
|
||
| # For now, process known packages | ||
| # In production, this would discover all packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this vibe coded by any chance ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @TG1999 — no, this wasn’t “vibe coded.”
I intentionally kept this importer minimal to get a working v2 pipeline and tests in place first. The current packages_data list is a deliberate placeholder so we can validate parsing and the new models . (it successfully imported ~28 CVEs for a test package).
| # In production, this would discover all packages | ||
| self.packages_data = [] | ||
|
|
||
| # Example package - can be expanded to fetch multiple packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this a scalable approach?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it’s not scalable as-is.
My next steps are to add package discovery, incremental processing, batching, and improved error handling/logging so it can run across the full Alpine repo. If you have a preferred approach , I’d love your input before I build out the full discovery flow.
Thanks for the review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TG1999 , can you suggest some plan for it !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would need to do some research for that, for now you can propose your full discovery flow. And if it looks good you can ahead and code that. Thanks!
Signed-off-by: karthiknew07 <karthik2005207@gmail.com>
b1ee85d to
a7df25f
Compare
Summary
This PR implements an importer for Alpine Linux APKBUILD files, addressing issue #509.
Changes
APKBUILDParserclass to parse secfixes sections from APKBUILD filesAlpineImporterclass for VulnerableCode integrationtest_alpine.pyIMPORTERS_REGISTRYHow It Works
The importer fetches APKBUILD files from Alpine Git repository and parses the secfixes format:
Testing
Related Issue
Fixes #509