Add logic to set addToInbox to true if messageId exists in event inbox #24550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where duplicate event messages (from retries) would be incorrectly processed directly instead of being recognized as already handled by the inbox system. The fix ensures that when a message already exists in the event inbox, the method returns true to indicate the event is handled, preventing duplicate processing.
Key changes:
- Added logic to set
addToInbox = truewhen a duplicate message is detected in the inbox - Added
virtualkeyword to three methods for better extensibility - Added clarifying comments explaining the duplicate message scenario
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
EngincanV
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #24549