Run dotnet build command before creating EF Core migrations
#24685
+27
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds a dotnet build command before creating EF Core migrations to ensure that projects are compiled before running EF migration commands. This is a practical improvement that can prevent migration failures due to compilation errors.
Changes:
- Added
dotnet buildcommand execution before migration creation in three different migration-related components - Includes error handling for build failures in InitialMigrationCreator
- Minor whitespace cleanup (trailing whitespace removal)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| EfCoreMigrationManager.cs | Added dotnet build before running dotnet ef migrations add command without error handling |
| InitialMigrationCreator.cs | Added dotnet build with proper error handling that returns early if build fails, plus whitespace cleanup |
| RecreateInitialMigrationCommand.cs | Added dotnet build before migration recreation without error handling |
framework/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/ProjectModification/EfCoreMigrationManager.cs
Outdated
Show resolved
Hide resolved
...work/src/Volo.Abp.Cli.Core/Volo/Abp/Cli/Commands/Internal/RecreateInitialMigrationCommand.cs
Outdated
Show resolved
Hide resolved
…on/EfCoreMigrationManager.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…/RecreateInitialMigrationCommand.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 task
EngincanV
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #24676