Skip to content

Pass ExclusionFilters to ReplaceEmbeddedByPhysical for letting developers define which files should be included or excluded#25284

Merged
maliming merged 2 commits intodevfrom
EngincanV/vfs-exclusion-filters
Apr 17, 2026
Merged

Pass ExclusionFilters to ReplaceEmbeddedByPhysical for letting developers define which files should be included or excluded#25284
maliming merged 2 commits intodevfrom
EngincanV/vfs-exclusion-filters

Conversation

@EngincanV
Copy link
Copy Markdown
Member

While building an ABP application, i needed this option to include the hidden files (.file-name) and directly use the file in debug mode.

…pers define which files should be included or excluded

Add an optional ExclusionFilters parameter (default: ExclusionFilters.Sensitive) to ReplaceEmbeddedByPhysical and forward it to the PhysicalFileProvider constructor when creating PhysicalVirtualFileSetInfo. This lets callers control which files are excluded when replacing embedded virtual file sets with physical directories.
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an ExclusionFilters option to ReplaceEmbeddedByPhysical so developers can control which files (including dotfiles) are included when swapping embedded VFS content for a physical file provider (e.g., in debug mode).

Changes:

  • Extend VirtualFileSetListExtensions.ReplaceEmbeddedByPhysical<T> to accept an ExclusionFilters parameter (defaulting to Sensitive).
  • Pass the provided ExclusionFilters into the PhysicalFileProvider used by ReplaceEmbeddedByPhysical.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 16, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 50.06%. Comparing base (4a6af1d) to head (46ea662).
⚠️ Report is 91 commits behind head on dev.

Files with missing lines Patch % Lines
.../VirtualFileSystem/VirtualFileSetListExtensions.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #25284      +/-   ##
==========================================
- Coverage   50.06%   50.06%   -0.01%     
==========================================
  Files        3557     3559       +2     
  Lines      119379   119580     +201     
  Branches     9010     9022      +12     
==========================================
+ Hits        59770    59862      +92     
- Misses      57808    57901      +93     
- Partials     1801     1817      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…ystem/VirtualFileSetListExtensions.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@maliming maliming merged commit 859e4dd into dev Apr 17, 2026
3 checks passed
@maliming maliming deleted the EngincanV/vfs-exclusion-filters branch April 17, 2026 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants