Conversation
1 task
Contributor
There was a problem hiding this comment.
Pull request overview
Updates ABP framework documentation to use the correct options-configuration pattern for AbpBackgroundJobWorkerOptions.ApplicationName, ensuring the sample actually takes effect for Default background jobs/workers when multiple apps share the same storage (fixing the misguidance described in #25291 / aligning with #23977 context).
Changes:
- Switches the sample override from
PreConfigureServicestoConfigureServices. - Switches the sample from
PreConfigure<AbpBackgroundJobWorkerOptions>toConfigure<AbpBackgroundJobWorkerOptions>in both Background Workers and Background Jobs docs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/en/framework/infrastructure/background-workers/index.md | Updates Default background job/worker isolation sample to use ConfigureServices + Configure<AbpBackgroundJobWorkerOptions>. |
| docs/en/framework/infrastructure/background-jobs/index.md | Same doc fix for the Background Jobs page to ensure ApplicationName configuration is applied. |
EngincanV
approved these changes
Apr 20, 2026
EngincanV
deleted the
fix/25291-default-background-job-worker-options-configure
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #25291
PreConfigure<AbpBackgroundJobWorkerOptions>actions are never applied because neitherAbpBackgroundJobsModulenorAbpBackgroundJobsAbstractionsModulecallsExecutePreConfiguredActions<AbpBackgroundJobWorkerOptions>(). Switch the docs toConfigureServices+Configure<AbpBackgroundJobWorkerOptions>to match the Hangfire/RabbitMQ samples and the fix in #23977.