fix(#25310): revent hanging when acquiring closed channel after rabbitmq restart#25311
Merged
maliming merged 7 commits intoabpframework:devfrom Apr 23, 2026
Merged
fix(#25310): revent hanging when acquiring closed channel after rabbitmq restart#25311maliming merged 7 commits intoabpframework:devfrom
maliming merged 7 commits intoabpframework:devfrom
Conversation
… after rabbitmq restart
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an ABP RabbitMQ channel-pool deadlock scenario that can occur after a RabbitMQ restart (as described in #25310), where acquiring a previously-closed channel could block indefinitely.
Changes:
- Moves
poolItem.Acquire()to occur only after validating/replacing a closed channel. - Ensures a closed pooled channel is disposed/removed and potentially recreated before any exclusive “in-use” lock is taken.
maliming
approved these changes
Apr 23, 2026
Member
|
Hi @scrapstation, thanks for the great catch and the fix! I pushed a few follow-ups on your branch — tightened the recovery path a bit so concurrent callers can't race into duplicate dispose/recreate, and added a small Really appreciate you digging into this one! |
…l; add barrier timeouts in tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #25310