Skip to content

Follow-up review fixes for MudBlazor PR #25393#25483

Merged
ismcagdas merged 1 commit into
rel-10.4from
maliming/mud-qa-followup
May 28, 2026
Merged

Follow-up review fixes for MudBlazor PR #25393#25483
ismcagdas merged 1 commit into
rel-10.4from
maliming/mud-qa-followup

Conversation

@maliming
Copy link
Copy Markdown
Member

Continues to address Copilot review comments left on #25393 and on the dev merge PR #25479.

Copilot AI review requested due to automatic review settings May 27, 2026 06:08
@maliming maliming added this to the 10.4-patch milestone May 27, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR follows up on prior MudBlazor-related review feedback by improving initial loading UX in the Setting Management page, adding accessibility labels to search fields, and adjusting the MudBlazor page progress service’s show/hide behavior.

Changes:

  • Add an explicit _loading state to SettingManagement to show a spinner during async initialization and avoid “stuck” loading based on SelectedGroup.
  • Add aria-label attributes to MudBlazor search inputs to improve screen-reader accessibility.
  • Refactor MudBlazorUiPageProgressService to track visibility and default options (but currently introduces non-thread-safe state updates).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
modules/setting-management/src/Volo.Abp.SettingManagement.Blazor.MudBlazor/Pages/SettingManagement/SettingManagement.razor.cs Introduces _loading state toggled during async initialization.
modules/setting-management/src/Volo.Abp.SettingManagement.Blazor.MudBlazor/Pages/SettingManagement/SettingManagement.razor Uses _loading to render a spinner and conditions tab rendering on available groups.
modules/permission-management/src/Volo.Abp.PermissionManagement.Blazor.MudBlazor/Components/PermissionManagementModal.razor Adds aria-label to the permission group search field.
modules/identity/src/Volo.Abp.Identity.Blazor.MudBlazor/Pages/Identity/UserManagement.razor Adds aria-label to the user list search field.
framework/src/Volo.Abp.MudBlazorUI/MudBlazorUiPageProgressService.cs Refactors progress notification logic; current implementation has concurrency issues around shared mutable state.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.42%. Comparing base (868c729) to head (c13a909).

Additional details and impacted files
@@            Coverage Diff            @@
##           rel-10.4   #25483   +/-   ##
=========================================
  Coverage     49.42%   49.42%           
=========================================
  Files          3670     3670           
  Lines        123599   123599           
  Branches       9453     9453           
=========================================
+ Hits          61083    61090    +7     
+ Misses        60682    60671   -11     
- Partials       1834     1838    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maliming maliming requested a review from ismcagdas May 27, 2026 09:34
@ismcagdas ismcagdas merged commit c569981 into rel-10.4 May 28, 2026
5 checks passed
@ismcagdas ismcagdas deleted the maliming/mud-qa-followup branch May 28, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants