Merged
Conversation
maliming
reviewed
Aug 31, 2020
| return null; | ||
| } | ||
|
|
||
| return httpContext.Request.Form[context.GetAbpAspNetCoreMultiTenancyOptions().TenantKey]; |
Member
There was a problem hiding this comment.
Use the async method to get value from the form will be better.
Maybe we should make ITenantResolver support async.
var form = await HttpRequest.ReadAsFormAsync();
return form["context.GetAbpAspNetCoreMultiTenancyOptions().TenantKey"];
Contributor
Author
There was a problem hiding this comment.
I agree. May resolve tenants from JSON, asynchronous is better. But this is a breaking change. @hikalkan What do you think?
Member
There was a problem hiding this comment.
We don't want to introduce such a breaking change now.
hikalkan
reviewed
Sep 15, 2020
...ication.OpenIdConnect/Microsoft/Extensions/DependencyInjection/AbpOpenIdConnectExtensions.cs
Show resolved
Hide resolved
Member
|
Thanks for the development and explanations ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #5213