Skip to content

Fix static methods.#612

Merged
abraham merged 4 commits intoabraham:mainfrom
LzpTec:main
May 10, 2021
Merged

Fix static methods.#612
abraham merged 4 commits intoabraham:mainfrom
LzpTec:main

Conversation

@tripodsgames
Copy link
Copy Markdown
Contributor

@tripodsgames tripodsgames commented Apr 15, 2021

This small change fixed support for static methods.

Closes #605.

@abraham
Copy link
Copy Markdown
Owner

abraham commented Apr 18, 2021

Are there some tests you could add to assure this continues to work?

@tripodsgames
Copy link
Copy Markdown
Contributor Author

tripodsgames commented Apr 18, 2021

Are there some tests you could add to assure this continues to work?

I checked the way that typescript emits decorators for static properties and created a test for it.

@tripodsgames
Copy link
Copy Markdown
Contributor Author

@abraham are you going to merge this soon? I want to use the npm package directly instead of the github url.

@abraham abraham merged commit 6f694cc into abraham:main May 10, 2021
@abraham
Copy link
Copy Markdown
Owner

abraham commented May 10, 2021

Released as part of v0.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uncaught TypeError: can't access property "hasOwnProperty", descriptor is undefined

2 participants