Bug: Unable to delete member

[VeddySama]

What were you trying to achieve?

An error occurs when deleting a member. The main fault comes from line 92 of pkg -> roles -> rolemanager -> api -> endpoints.go. The received removeEntityMembersReq is inconsistent with the decoded one.

What are the expected results?

Successfully deleted member

What are the received results?

Deleting member error

Steps To Reproduce

No response

In what environment did you encounter the issue?

Latest code

Additional information you deem important

No response

[dborovcanin]

@arvindh123 Please take a look at this one.

[felixgateru]

Hello @VeddySama,
I have tested this one by removing a role member from each of the entities and this works as expected. Could you please test again to see if the issue was resolved. If not could you provide more context on which specific request you encountered the error in? What is the error log?

[VeddySama]

Hello @VeddySama,  你好 I have tested this one by removing a role member from each of the entities and this works as expected. Could you please test again to see if the issue was resolved. If not could you provide more context on which specific request you encountered the error in? What is the error log?

When using the DELETE /roles interface, the parameters parsed by d.DecodeListEntityMembers are used. The structure returned by this method is listEntityMembersReq, but the type received in RemoveEntityMembersEndpoint is removeEntityMembersReq.

r.Delete("/", otelhttp.NewHandler(kithttp.NewServer(
			RemoveEntityMembersEndpoint(svc),
			d.DecodeListEntityMembers,
			api.EncodeResponse,
			opts...,
		), "delete_entity_members").ServeHTTP)

func (d Decoder) DecodeListEntityMembers(_ context.Context, r *http.Request) (interface{}, error) {
	o, err := apiutil.ReadNumQuery[uint64](r, api.OffsetKey, api.DefOffset)
	if err != nil {
		return nil, errors.Wrap(apiutil.ErrValidation, err)
	}

	l, err := apiutil.ReadNumQuery[uint64](r, api.LimitKey, api.DefLimit)
	if err != nil {
		return nil, errors.Wrap(apiutil.ErrValidation, err)
	}

	order, err := apiutil.ReadStringQuery(r, api.OrderKey, "")
	if err != nil {
		return nil, errors.Wrap(apiutil.ErrValidation, err)
	}

	dir, err := apiutil.ReadStringQuery(r, api.LimitKey, "")
	if err != nil {
		return nil, errors.Wrap(apiutil.ErrValidation, err)
	}

	accessProviderID, err := apiutil.ReadStringQuery(r, api.AccessProviderIDKey, "")
	if err != nil {
		return nil, errors.Wrap(apiutil.ErrValidation, err)
	}

	accessType, err := apiutil.ReadStringQuery(r, api.AccessTypeKey, "")
	if err != nil {
		return nil, errors.Wrap(apiutil.ErrValidation, err)
	}

	roleId, err := apiutil.ReadStringQuery(r, api.RoleIDKey, "")
	if err != nil {
		return nil, errors.Wrap(apiutil.ErrValidation, err)
	}

	roleName, err := apiutil.ReadStringQuery(r, api.RoleNameKey, "")
	if err != nil {
		return nil, errors.Wrap(apiutil.ErrValidation, err)
	}

	allActions, err := apiutil.ReadStringQuery(r, api.ActionsKey, "")
	if err != nil {
		return nil, errors.Wrap(apiutil.ErrValidation, err)
	}

	actions := []string{}

	allActions = strings.TrimSpace(allActions)
	if allActions != "" {
		actions = strings.Split(allActions, ",")
	}

	req := listEntityMembersReq{
		token:            apiutil.ExtractBearerToken(r),
		entityID:         chi.URLParam(r, d.entityIDTemplate),
		limit:            l,
		offset:           o,
		order:            order,
		dir:              dir,
		accessProviderID: accessProviderID,
		roleId:           roleId,
		roleName:         roleName,
		actions:          actions,
		accessType:       accessType,
	}
	return req, nil
}

func RemoveEntityMembersEndpoint(svc roles.RoleManager) endpoint.Endpoint {
	return func(ctx context.Context, request interface{}) (interface{}, error) {
		req := request.(removeEntityMembersReq)
		if err := req.validate(); err != nil {
			return nil, errors.Wrap(apiutil.ErrValidation, err)
		}

		session, ok := ctx.Value(api.SessionKey).(authn.Session)
		if !ok {
			return nil, svcerr.ErrAuthentication
		}

		if err := svc.RemoveEntityMembers(ctx, session, req.entityID, req.MemberIDs); err != nil {
			return nil, err
		}
		return deleteEntityMembersRes{}, nil
	}
}

[dborovcanin]

Linked issue: #2601. Once we solve that one, this problem should also be solved.