Bug: Running make run_addons vault removes supermq-base-net and causes Docker error

[nintran52]

What were you trying to achieve?

I was trying to launch the Vault addon service by running:
make run_addons vault

after having already launched the main SuperMQ services via:
make run

What are the expected results?

I expected Vault to start normally and join the existing supermq-base-net Docker network without affecting or removing the network.

What are the received results?

While trying to run make run_addons vault, I received this error:

 ✔ Network nintran52_supermq_supermq-base-net  Removed                                  
Error response from daemon: error while removing network: network nintran52_supermq_supermq-base-net id...

This error shows that make run_addons vault attempted to remove the network supermq-base-net, which still had active endpoints attached from running services.

Steps To Reproduce

Start main SuperMQ services:
make run

Start the Vault addon:
make run_addons vault

Observe that Docker tries to remove the supermq-base-net network and encounters an error.

In what environment did you encounter the issue?

OS: macOS 14.4.1 (Sonoma)

Docker Desktop version: 4.40.0

Docker Engine version: 28.0.4

Docker Compose version: 2.34.0

Additional information you deem important

• The supermq-base-net network is created and used by both main services (make run) and addons (make run_addons vault).

• Running make run_addons vault independently tries to recreate the network even though it already exists and is in use.

• Modify docker/addons/vault/docker-compose.yaml to mark the network supermq-base-net as external: true.

• Example change:

networks:
  supermq-base-net:
    external: true

• This way, Vault will join the existing network instead of trying to recreate or remove it.

[dborovcanin]

This bug has been fixed by the mentioned pull requests.